Fix system test under Datastore Emulator. (Fixes #118) #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve usage of Datastore Emulator by not requiring credentials to be set. Rewrite failing system test to work around emulator discrepency with ``more_results`` field of ``QueryResultsBatch`` message. See: googleapis/google-cloud-datastore#130 Update the ``more`` return value of ``Query.fetch_page`` to be ``False`` if an empty page has just been retrieved. This is intended to prevent possible infinite loops in client code when using the Datastore emulator.
googlebot
added
the
cla: yes
crwilcox
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
crwilcox
approved these changes
Jun 24, 2019
crwilcox
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
cguardia
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve usage of Datastore Emulator by not requiring credentials to be
set.
Rewrite failing system test to work around emulator discrepency with
more_resultsfield ofQueryResultsBatchmessage.See: googleapis/google-cloud-datastore#130
Update the
morereturn value ofQuery.fetch_pageto beFalseif an empty page has just been retrieved. This is intended to prevent
possible infinite loops in client code when using the Datastore
emulator.
Fixes #118